Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix licenses that "assertain" to MM files. #455

Merged
merged 3 commits into from
Sep 12, 2018

Conversation

emilymye
Copy link
Contributor

  • Replace if false with erb comment blocks.
  • Use a word that is real/easier to spell than "assertains"

[all]

[terraform]

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

@rambleraptor
Copy link
Contributor

Hi, you're my favorite person.

Can you un-commit the changes to the build/ directory? Otherwise, this is probably good to go!

@emilymye emilymye force-pushed the rename_all_the_things branch from 83968ec to 7ae625b Compare September 12, 2018 01:12
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#91

@rambleraptor rambleraptor self-requested a review September 12, 2018 02:38
@rambleraptor
Copy link
Contributor

Huh, would you look at that? I should fix that one weird Ansible file.

Copy link
Contributor

@nat-henderson nat-henderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you un-commit the submodule updates.

@emilymye emilymye force-pushed the rename_all_the_things branch from 7ae625b to 421b1fd Compare September 12, 2018 19:45
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit d7a9e52) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 316bff2) have been included in your existing downstream PRs.

@emilymye emilymye force-pushed the rename_all_the_things branch from ef63af5 to 4b1818d Compare September 12, 2018 21:39
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 554525d) have been included in your existing downstream PRs.

Tracked submodules are build/puppet/_bundle build/puppet/auth build/puppet/bigquery build/puppet/compute build/puppet/sql build/puppet/storage build/puppet/spanner build/puppet/container build/puppet/dns build/puppet/pubsub build/puppet/resourcemanager build/chef/_bundle build/chef/auth build/chef/compute build/chef/sql build/chef/storage build/chef/spanner build/chef/container build/chef/dns build/chef/iam build/terraform build/ansible.
@modular-magician modular-magician merged commit 71ec7f7 into master Sep 12, 2018
@rileykarson
Copy link
Member

Would you mind making an event in your calendar ~a week out to run whatever script you ran again? Just in case we committed old-format ones in the interim.

@emilymye
Copy link
Contributor Author

emilymye commented Sep 13, 2018

@rileykarson 👍 the script is called "sublime find-replace is pretty dope"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants